Skip to content

Conversation

@jamezp
Copy link
Contributor

@jamezp jamezp commented Oct 10, 2025

We look to be in pretty good shape with really only one commit missing. This pull request does include two commits, but one is an undo of something from the first commit.

The only other commit we could potentially want would be #1210. However, we could do that separately once we decide what we want to do there.

@mkarg
Copy link
Contributor

mkarg commented Oct 11, 2025

Thank you for investing your time to sort this out! 😅

I'm +1 for adopting #1210, but I am also okay with deferring this question post merge. And yes, please drop all unused branches and update our branchlist in our wiki accordingly (as we tried to months back).

Copy link
Contributor

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim-krueger
Copy link
Contributor

+1, Thanks James!

@jamezp
Copy link
Contributor Author

jamezp commented Oct 13, 2025

Are we able to fast track this one given it was already merged into another branch?

@arjantijms
Copy link
Contributor

Are we able to fast track this one given it was already merged into another branch?

I'd say yes

@mkarg
Copy link
Contributor

mkarg commented Oct 14, 2025

Are we able to fast track this one given it was already merged into another branch?

Once a commit was merged into any branch once (i. e. it successfully passed all our rules and votings), there is no additional waiting time. It can cherry-picked into any other branch immediately, without any new PR needed. At least there is no rule (neither in the Eclipse Developer Manual nor in our own Committer Agreement) that forbids that.

@jamezp jamezp merged commit f624768 into jakartaee:main Oct 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants