Open
Conversation
jakezatecky
reviewed
Mar 8, 2020
Owner
jakezatecky
left a comment
There was a problem hiding this comment.
Hello @ZHamburglar and thank you for the PR!
I have reviewed the changes and have run the examples. Everything seems to be fine. However, this PR adds a lot of additional changes to the code base when I think this display change could best be implemented in a user's code.
For example, I think the following CSS-related changes would achieve the same thing this PR accomplishes:
.rct-collapse {
order: 1;
margin-left: auto;
}Would such a CSS change be usable under your use case? The reason I ask is because there are a lot of properties and tested elements already in this library and I want to reduce maintenance burden when some things can be done by users of the library with minor changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.