-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Remember Me feature #276
base: master
Are you sure you want to change the base?
Conversation
Coool one :) |
Thanks :-) |
This would be quite nice to have :) Is there anything holding it back from being merged? I would be willing to do some work if it needs to be polished up. |
really don't know why it's not merged yet ! Thanks for your support :-) |
@jaliss Any comments? I really like your work on securesocial, but this is a bit that is missing for me. |
+1 |
1 similar comment
+1 |
@bahymohammmed is this working for you? From what I see you are making the cookie transient if the user checks on the "remember me" option at login time. |
This would really help speed up dev time, so one doesn't have to re-login after each server reload... |
@AdrianScott if you want to prevent loosing your session on reach reload you can write your own version of the AuthenticatorStore (that does not use the Play cache) or configure the Play cache so that it persists things in disk. To do that change the ehcache.xml file and set diskPersistent="true". |
Thank you! I appreciate it. (still needing a 'remember me' for my users sometime soon also, hehe ) |
@AdrianScott you're welcome. Will keep this in mind :) |
+1 (Any news on integrating this? I think this is a very important feature I would really appreciate) |
Hi! I'm currently needing this feature. Any news? |
Why not merged this feature ? I need It! It is very important feature! |
This is a new feature to add remember me feature in login view.
Here's the change log:
Authenticator
I've changedtoCookie
method signature to accept a new argument which isrememberCookie
as booleanLoginInfo
object instead of acceptingtuple(String, String)
case class LoginInfo(username: String, password: String, remember: Option[Boolean])
to be used in the new formloginFormWithoutRemember
instead of accepting two strings as username and password, so we pass the remember me option along side with the credentialslazy val withRememberMe = current.configuration.getBoolean(RememberMe).getOrElse(false)
/views/provider.scala.html