Change UserService trait to use the GenericProfile trait as the user type, instead of locking in the BasicProfile case class #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing the GenericUser trait everywhere. This causes a handful of minor ripple changes in other bits of code.
| @@ -121,7 +121,7 @@ trait BasePasswordReset[U] extends MailTokenBasedOperations[U] { | |||
| case Some(profile) => | |||
| val hashed = env.currentHasher.hash(p._1) | |||
| for ( | |||
| updated <- env.userService.save(profile.copy(passwordInfo = Some(hashed)), SaveMode.PasswordChange); | |||
| updated <- env.userService.save(BasicProfile.from(profile).copy(passwordInfo = Some(hashed)), SaveMode.PasswordChange); | |||
There was a problem hiding this comment.
This is the extent of real code changes. Since you can't enforce that a GenericProfile has a copy constructor, I'm using the BasicProfile to affect this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it isn't possible to subclass a case class, and implementors may have a different structure for users than the
BasicProfile, and in general, it is best to stick to the Robustness Principle (and I'm guessing this is why theGenericProfiletrait exists in the first place?)In my case, I needed this because I am migrating from an old version of SecureSocial, where the
IdentityIdwas a thing. I didn't want to migrate all of my user records in mongo, or tack on a transformation step in my DB layer. I imagine others may have other reasons for wanting to have the freedom to implementGenericProfiledifferently.Of course, implementors are still free to just use
BasicProfile.