This PR changes the puzzle fetching logic to use the external ChessGubbins API and introduces difficulty level filtering based on user settings. #156

sandeepbhanja · 2025-06-18T10:41:25Z

No description provided.

… to user settings for filtering puzzle based on difficulty

jalpp · 2025-06-18T12:02:32Z

hello @sandeepbhanja thanks for the PR, please do fix the build run in the settingSchema class

sandeepbhanja · 2025-06-18T12:24:41Z

Hi , I had forgotten to push a file , I have made the changes , the build run has passed.
Sorry for the inconvenience
Please let me know if there are any modifications or additional tests you would like me to include. I’m happy to make any necessary adjustments.

jalpp · 2025-06-18T12:30:03Z

You also need to update contributing.md and Readme regarding the use of chessgubbins so it's better documented.

…me.md and Contributing.md

sandeepbhanja · 2025-06-18T13:00:41Z

Hi , I have updated the files
Please let me know if there are any modifications or additional tests you would like me to include. I’m happy to make any necessary adjustments.
Sorry for the inconvenience

jalpp · 2025-06-18T13:20:47Z

Hi , I have updated the files Please let me know if there are any modifications or additional tests you would like me to include. I’m happy to make any necessary adjustments. Sorry for the inconvenience

looks great, I will test it locally and merge after, no worries, these PR helps alot!

jalpp

I have left few changes that need to be addressed, right now the puzzle search fails on edge cases and its not prod ready yet

jalpp · 2025-06-18T17:02:13Z

chesslise/src/main/java/discord/mainhandler/CommandBuilder.java

@@ -93,8 +92,8 @@ public void registerSlashMultipleOptionCommand() {
                new OptionData(OptionType.STRING, "difficulty", "pick the engine difficulty", true)
                        .addChoice("Easy", "5").addChoice("Medium", "10").addChoice("Hard", "15"));

-        buildSlashMultipleOption("setting", "set Chesslise settings like board theme & piece type",
-                SettingSchema.getBoardThemeData(), SettingSchema.getPieceTypeData());
+        buildSlashMultipleOption("setting", "set Chesslise settings like board theme, piece type and difficulty level",


can you make it "puzzle difficulty" in general difficulty can mean alot of things in chess

jalpp · 2025-06-18T17:03:10Z

chesslise/src/main/java/setting/SettingSchema.java

@@ -44,4 +48,11 @@ public static OptionData getPieceTypeData() {
                .addChoice("pixel", "pixel");
    }

+    public static OptionData getDifficultyLevelType(){


can we follow the same naming scheme it should be getPuzzleDifficultyData()

jalpp · 2025-06-18T17:04:49Z

chesslise/src/main/java/lichess/LichessPuzzleSearch.java

+                JSONParser parser = new JSONParser();
+                JSONObject jsonObject = (JSONObject) parser.parse(response.body());
+                int difficultyLevel = Integer.parseInt(jsonObject.get("rating").toString());
+                if(!isValidDifficulty(difficultyLevel, settingSchema.getDifficultyLevel())){


When tested locally, the code breaks if the user hasn't set any puzzle settings, which is null. This is likely the case for most users, as they are not aware that such a new setting exists, resulting in an infinite while loop. Can you make sure you check for nulls in the settingSchema

jalpp · 2025-06-18T17:06:02Z

chesslise/src/main/java/lichess/LichessPuzzleSearch.java

+    private static final String puzzleUrl = "https://api.chessgubbins.com/puzzles/random?themes=";
+
+    private static final HttpClient client = HttpClient.newHttpClient();
+


this function fails for opening theme for some reason, can you address why is that if the API doesn't support the theme it should revert to local search

jalpp · 2025-06-18T17:07:02Z

chesslise/src/main/java/lichess/LichessPuzzleSearch.java

+    private static final HttpClient client = HttpClient.newHttpClient();
+
+
+    private static List<List<String>> searchPuzzles(String searchColumn, String searchValue, int maxPuzzles, String userId) {


can we rename this to searchPuzzlesGubbinsApi or something similar it is confusing if its searching locally or via API

jalpp · 2025-06-18T17:07:28Z

chesslise/src/main/java/setting/SettingSchema.java

@@ -8,11 +8,13 @@ public class SettingSchema {
    private final String userid;
    private final String boardTheme;
    private final String pieceType;
+    private final String difficultyLevel;


handle null case please

jalpp · 2025-06-18T17:08:46Z

chesslise/src/main/java/lichess/ThemePuzzle.java

@@ -13,9 +13,9 @@ public class ThemePuzzle extends PuzzleView implements Puzzle {
    private final String theme;
    private final LichessDBPuzzle currentPuzzle;



can we let users know they can change the puzzle difficulty via settings in the theme card description? People might complain why they are only seeing easy puzzles

jalpp · 2025-06-18T17:09:25Z

chesslise/src/main/java/setting/SettingHandler.java

        } else {
-            return new SettingSchema("blue", "kosal", userid);
+            return new SettingSchema("blue", "kosal", userid,"Easy");


can we make it set to medium, generally people don't like easy puzzles as the chesslise users want to improve and try harder puzzles

jalpp · 2025-06-18T17:10:18Z

README.md

@@ -32,6 +32,7 @@ Chesslise integrates with **multiple powerful chess APIs** to provide a high-qua
 - ♟️ [JDA 5 (Discord API)](https://github.com/DV8FromTheWorld/JDA)
 - ♟️ [Stockfish API](https://stockfish.online/)
 - ♟️ [ChessDB CN (Opening Book)](https://chessdb.cn/cloudbookc_info_en.html)
+- ♟️ [Chessgubbins Puzzle API](https://chessgubbins.com) – Provides random puzzles based on themes.


we don't need the description, follow how its done with other api links

jalpp · 2025-06-18T17:11:27Z

CONTRIBUTING.md

+## Puzzle API Integration: Chessgubbins
+Chesslise now utilizes the [Chessgubbins Puzzle API](https://chessgubbins.com) to fetch random puzzles based on the LichessDB theme through the `LichessPuzzleSearch` class. This integration allows for more varied and updated puzzles.
+
+If the Chessgubbins API is temporarily unavailable, Chesslise falls back to using a local CSV database (`lichess_db_puzzle.csv`). When contributing to the project:


this should mention devs should get the lichess_db_puzzle.csv from Lichess's puzzle db site and should download locally and test it,

jalpp · 2025-06-18T17:13:16Z

I also suggest to add some test files for fetching the API and making sure it works, thats optional though

sandeepbhanja · 2025-06-19T07:07:57Z

Hi , I have fixed the issues and raised a PR
Please let me know if there are any modifications or additional tests you would like me to include. I’m happy to make any necessary adjustments.

Refactor puzzle fetching to use external API and add difficulty level…

b701186

… to user settings for filtering puzzle based on difficulty

sandeepbhanja mentioned this pull request Jun 18, 2025

Use Random Puzzle API instead of local puzzle search #153

Closed

Adding SettingHandler.java

2f1e52a

sandeepbhanja added 3 commits June 18, 2025 18:16

changes done to add information about chessgubbins Puzzle API in Read…

07dd17f

…me.md and Contributing.md

changes done to add documentation of chessgubbins api in contributing.md

271075b

updated contributing.md

dd531f0

jalpp reviewed Jun 18, 2025

View reviewed changes

changes done to fix the issues and handle edge cases for API calls

c8cfa39

jalpp changed the base branch from master to puzzleapi June 19, 2025 17:36

jalpp merged commit 2be1904 into jalpp:puzzleapi Jun 19, 2025
1 check passed

		private static final String puzzleUrl = "https://api.chessgubbins.com/puzzles/random?themes=";

		private static final HttpClient client = HttpClient.newHttpClient();

		private static final HttpClient client = HttpClient.newHttpClient();


		private static List<List<String>> searchPuzzles(String searchColumn, String searchValue, int maxPuzzles, String userId) {

		@@ -13,9 +13,9 @@ public class ThemePuzzle extends PuzzleView implements Puzzle {
		private final String theme;
		private final LichessDBPuzzle currentPuzzle;

This PR changes the puzzle fetching logic to use the external ChessGubbins API and introduces difficulty level filtering based on user settings. #156

This PR changes the puzzle fetching logic to use the external ChessGubbins API and introduces difficulty level filtering based on user settings. #156

Uh oh!

Conversation

sandeepbhanja commented Jun 18, 2025

Uh oh!

jalpp commented Jun 18, 2025

Uh oh!

sandeepbhanja commented Jun 18, 2025

Uh oh!

jalpp commented Jun 18, 2025

Uh oh!

sandeepbhanja commented Jun 18, 2025

Uh oh!

jalpp commented Jun 18, 2025

Uh oh!

jalpp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jalpp Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jalpp commented Jun 18, 2025

Uh oh!

sandeepbhanja commented Jun 19, 2025

Uh oh!

Uh oh!

Uh oh!

jalpp Jun 18, 2025 •

edited

Loading