Skip to content

CON-5523-building-on-ventura #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025
Merged

CON-5523-building-on-ventura #32

merged 2 commits into from
Mar 19, 2025

Conversation

sameh0
Copy link
Contributor

@sameh0 sameh0 commented Jan 9, 2025

No description provided.

@radimcervinka
Copy link

Hello, I am totally out of context for such review, is it necessary to add the whole apple natives write group as reviewers?

@JacobHearst
Copy link
Contributor

Hello, I am totally out of context for such review, is it necessary to add the whole apple natives write group as reviewers?

I think this is a great topic for the next ANIE @radimcervinka! I don't think it's necessary to add the entire group but I do think the question of who should be added merits some discussion.

@sameh0
Copy link
Contributor Author

sameh0 commented Jan 15, 2025

@radimcervinka, I don’t recall doing that. Perhaps it’s automatic, but as @JacobHearst mentioned, it’s worth discussing.
One option could be just sharing the PR link on the shared code channels or maybe create an apple natives reviewers group with one dev representing each team.
For shared packages, we should ensure that other teams are aware of the updates and it’s not breaking anyone’s codebase (which isn’t the case for this PR, of course). It would also be interesting to determine who the owners and reviewers of shared packages are. I know that Caribou contributed significantly to Subprocess recently, but it’s not exclusively maintained by us.

@sameh0 sameh0 force-pushed the CON-5523-building-on-ventura branch from b1bb9b0 to a931a71 Compare March 19, 2025 17:51
@sameh0 sameh0 merged commit 8fdaf02 into main Mar 19, 2025
3 checks passed
@sameh0 sameh0 deleted the CON-5523-building-on-ventura branch March 19, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants