Skip to content

Add missing Makefile.in files from Opus distribution #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

softins
Copy link
Member

@softins softins commented Apr 7, 2025

Short description of changes

Two instances of Makefile.in were accidentally omitted from the Opus sources in #3409 due to a rule in .gitignore.
This commit also updates .gitignore not to ignore them.

Makefile.in is not required when building Jamulus from Jamulus.pro, but is needed if experimenting with ./configure in the Opus directory to try out new configuration options.

CHANGELOG: Internal: Add missing Makefile.in files to Opus 1.5.2 distro.

Context: Fixes an issue?

No, but was discovered while reviewing #3487

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Ready to merge. No effect on current builds.

What is missing until this pull request can be merged?

Only review

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

Two instances of Makefile.in were accidentally omitted due to
a rule in .gitignore. Also update .gitignore not to ignore them.
@softins softins added this to the Release 3.12.0 milestone Apr 7, 2025
@softins softins requested review from pljones and ann0see April 7, 2025 17:03
@pljones
Copy link
Collaborator

pljones commented Apr 7, 2025

Should we build the OPUS library using its own build system, rather than using Jamulus.pro directly? Is there a platform-independent way to do that? (That's where including it in Jamulus.pro is most likely to be the best way, I guess...)

@softins softins added this to Tracking Apr 7, 2025
@github-project-automation github-project-automation bot moved this to Triage in Tracking Apr 7, 2025
@softins
Copy link
Member Author

softins commented Apr 7, 2025

Should we build the OPUS library using its own build system, rather than using Jamulus.pro directly? Is there a platform-independent way to do that? (That's where including it in Jamulus.pro is most likely to be the best way, I guess...)

Certainly worth exploring, although I don't know how platform independent the configure stuff is.

But getting these missing files in, that were overlooked in #3409 is an essential first step.

@pljones pljones merged commit b2e0776 into jamulussoftware:main Apr 9, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Tracking Apr 9, 2025
@softins softins mentioned this pull request Apr 20, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants