Avoid sleeping on windows if connected #3498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #3499 to run the CI |
|
Linux might be the next step (in another PR). |
softins
approved these changes
May 6, 2025
There was a problem hiding this comment.
I haven't tested it myself, but the changes look sensible, and appear to comply with the Win32 API docs.
On a related note, I have noticed for a long time that Jamulus on my Mac prevents display dimming or sleeping all the time it is running, and I have thought that it would be better if it did so only while connected, similar to this PR. Maybe another PR could change the behaviour on Mac to match that of this PR?
pljones
reviewed
May 6, 2025
ann0see
force-pushed
the
autobuild/addWindowsSleep
branch
from
261e791 to
881b416
Compare
|
It should be fixed now |
Probably. I suppose it would be related to the objective c code we include on macOS builds |
pljones
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Avoids Windows to go into sleep mode if the client is connected to a server
CHANGELOG: Windows: Avoid screensaver or sleeping if connected to a server
Context: Fixes an issue?
Related to: #834
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review. A pre-build was tested on Win 11 and it worked as expected: If a connection to the server stands, the device does not sleep. Once it is disconnected, it will sleep.
What is missing until this pull request can be merged?
Testing on another system.
Checklist