feature: Unbox var interning in the IR #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeaye
requested changes
Apr 5, 2025
| { | ||
| auto const ns_string{ native_persistent_string(ns) }; | ||
| __rt_ctx->intern_ns(ns_string); | ||
| auto const name_string{ native_persistent_string(name) }; |
There was a problem hiding this comment.
No need for lines 100 or 102. They're costing us two extra allocations!
There was a problem hiding this comment.
Are you saying that it will implicitly call the constructor to turn the c-string into a persistent string when we pass the parameter? If so, isn't that the same amount of allocations as it is passed by reference into intern_ns and intern_var?
|
Nice work, Monty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new c_api function
jank_var_intern_cused for interning vars just with c strings.