Handle State encoding issue inbound from Provider #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…character. This is to resolve an issue with the way AWS Cognito returns the state on the querystring. Cognito does not properly encode the `+` char to `%2B`, which turns into a whitespace char inbound to the Strategy.
|
Bump to the repo maintainers! Would love to see this fix integrated to an official openidconnect version, so I don't have to reference a custom fork. |
|
@jaredhanson Please merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix updates
SessionStore.verifyto convert whitespace into the+character.This is to resolve an issue with the way AWS Cognito returns the state on the querystring. Cognito does not properly encode the
+char to%2B. This causes the query string state to become a whitespace char. The failure occurs when the verify function does an equality check against inbound query string state and the session state.example:
inbound query string state :
asd hfds joriginal session state :
asd+hfds+j