Simplify replaceAll and splitAll in Hakyll.Core.Util.String #1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`(=~~)` is polymorphic in its return type. Get first match + before/after directly, instead of splitting manually on match indices. Moreover, since `=~~` uses `'fail'` on lack of match, and `Maybe` is an instance of `MonadFail`, `listToMaybe` isn't necessary.
|
Thank you for your contribution! While we're touching these functions, would you mind adding a few test cases here? |
Prevent infinite loop when pattern is `.*`.
|
Here you go. Even found a bug! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(=~~)is polymorphic in its return type. Get first match + before/after directly, instead of splitting manually on match indices. Moreover, since=~~uses'fail'on lack of match, andMaybeis an instance ofMonadFail,listToMaybeisn't necessary.