Skip to content

Fix: #151 saving edited events via modal #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Fix: #151 saving edited events via modal #152

merged 1 commit into from
Nov 1, 2024

Conversation

LexMonster
Copy link
Contributor

@LexMonster LexMonster commented Oct 26, 2024

The edit modal was pushing the "edited" event into the calendar events instead of replacing it.

Pull Request Description

When the addEventWithModal is called with an event as parameter it now assumes that it is editing. As such it will replace the old event with the new event based on its id instead of just pushing it to the data to be saved.

Related Issues

Fixes #151

Checklist

  • I have read the contribution guidelines and code of conduct.
  • I have tested the changes locally and they are working as expected.
  • I have added appropriate comments and documentation for the code changes.
  • My code follows the coding style and standards of this project.
  • I have rebased my branch on the latest main (or master) branch.
  • All tests (if applicable) have passed successfully.
  • I have run linters and fixed any issues.
  • I have checked for any potential security issues or vulnerabilities.

BEGIN_COMMIT_OVERRIDE
fix: Saving edited events via modal no longer duplicates events (close #151). Thanks @LexMonster.
END_COMMIT_OVERRIDE

The edit modal was pushing the "edited" event into the calendar events instead of replacing it.
@valentine195 valentine195 merged commit 1c5b8cd into javalent:main Nov 1, 2024
1 check passed
@LexMonster LexMonster deleted the fix/#151-duplication-of-events-in-data-on-edit branch November 5, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifying Events directly from the Sidebar Calendar creates duplicate Events in Settings
2 participants