Add --use_dft for more precise measurements #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the scope's built-in Vpp measurement, fetch the 1200 point screen display data and do a Fourier transform on it. This way the phase and amplitude is averaged over all samples, which allows more precise measurements than an 8-bit ADC would normally give.
vizkoze
reviewed
Dec 19, 2020
| awg.setfrequency(AWG_CHANNEL, float(freq)) | ||
| time.sleep(TIMEOUT) | ||
|
|
||
| if not args.NORMALIZE: |
There was a problem hiding this comment.
might i ask why you got rid of the normalize option? just curious
There was a problem hiding this comment.
It was moved below to line 134 to avoid duplicating it.
vizkoze
reviewed
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for sharing the script!
I've added an option to download the screen data and perform Fourier transform on it. This way the amplitude and phase are averaged over all samples, giving more accurate results than an 8-bit ADC would normally allow. It's a bit slower than scope's built-in measurements, so I added it as a separate option.
Here are some examples of an RC filter, first with traditional Vpp measurement method:
And then with DFT method: