-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C89 patch #45
base: master
Are you sure you want to change the base?
C89 patch #45
Conversation
Why is this change necessary? |
If you use an old compiler which does not support C99 by default. |
I can't imagine what the problem is with the c89 compiler. If an error occurs in the original source, I would like to see the contents of that error. |
@polluks I can't reproduce this issue on Linux. Since you're trying to upstream a patch for MacPorts, I presume you're trying to add support for a Mac - but what kind? Please tell us your exact target platform, your toolset, and reproduction steps. @jca02266 I cannot reproduce this error, but there is another.
Results:
Patch:
This patch fixes the compilation:
Unit test results:
|
@grepwood Well, try to use an old gcc2. I didn't make the patch, maybe MacPorts wants to support old compilers. |
See https://github.com/macports/macports-ports/blob/master/archivers/lha/files/c89.patch