Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove likely unnecessary default_name, fixes broken 2023.9 #131

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

gagebenne
Copy link
Contributor

Closes #119.

Could add child slug (Baby Buddy API unique identifier) in case you want more unique identifiers.

@jcgoette
Copy link
Owner

jcgoette commented Sep 8, 2023

This works (for whatever reason??), but let's change to name instead of removing completely.

@gagebenne
Copy link
Contributor Author

gagebenne commented Sep 8, 2023

Yeah, wasn't sure if name had to be unique for devices, but makes more sense to be human readable first, last. Also -- did you still want Baby prefixing the sensor device name?

@jcgoette
Copy link
Owner

jcgoette commented Sep 8, 2023

Ha, yea, I just noticed sensor.py had "Baby" prefix and switch.py didn't. I don't feel strongly either way and I think it will either break nothing or break things equally.

@gagebenne
Copy link
Contributor Author

Ha, yea, I just noticed sensor.py had "Baby" prefix and switch.py didn't. I don't feel strongly either way and I think it will either break nothing or break things equally.

Just ran these changes, nothing seemed to break in my setup!

@jcgoette
Copy link
Owner

jcgoette commented Sep 8, 2023

I meant by changing both to be consistent. Which we should do.

@jcgoette jcgoette merged commit 5531cce into jcgoette:main Sep 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home Assistant 2023.8.0: Invalid Device Info
2 participants