Use PyType_GetDict in Python 3.12+
#745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were incorrectly accessing `tp_dict` in mixin classes when defining a `Struct` class on Python 3.12+. This could result in a segfault if a user tried to create a `Struct` class that also subclassed from an interpreter builtin type (like `Exception`). Now we error nicely instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were incorrectly accessing
tp_dictin mixin classes when defining aStructclass on Python 3.12+. This could result in a segfault if a user tried to create aStructclass that also subclassed from an interpreter builtin type (likeException). Now we error nicely instead.Fixes #727.