Open
Conversation
Update Facebook-Delete-ActivityLog-SearchHistory.js
…rray for innerText values
…chHistory function
…tempts using parameters and improve retry logic
…eteFacebookActivityLog_SearchHistory function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thanks for the script, I am no JS wizard and it helped me a lot. I noticed you wrote that you wanted to test each different activity logs before compiling everything in one script, but your Readme only mentions one script.
So I tested it on the following logs :
For the last two to work, and this is my PR, I added to other text to check against the
innerTextvar, and their further rationalized it by putting it in an upper constant, making it easier to edit.Sometimes the script seems to stop working and I have to relaunch it by hand, but it happened before I did this edit, and I guess this kind of script is doomed to be buggy, seeing how complicated Facebook UI is ?