-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tabs #102
Adding tabs #102
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/jdan/98css/1ts17nxjj |
I tried to add some placeholder documentation for tabs. About javascript implementation: I planned to make a few changes in favor of multi-row tabs soon. Stay tuned. |
Hey @JuanGaray93 this one LGTM, wanna give it a stamp? |
<h3 id="tabs">Tabs</h3> | ||
<div> | ||
<blockquote> | ||
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the quote's missing
This looks very good! I think the |
The tabs header isn't in the sidebar. |
@CaptainFalcon92 , @jdan any working demo for this! I have a need for this in a project am working on. thanks |
any demo? would like to use this |
Taking over this PR -- the original branch has been deleted but I can still see the diff. |
Merged here. |
This is a re-opening of closed pull-request - #32 - reproducing W98 tabs - #21.
I looked at how tabs behaves in W98 and it looks like normal tabs are justified left.
Then only when tabs become multi-rows then they are justified in full width.
Also i think i remember the row where belongs the active tabs is always pulled down, isn't it ?
Here are some single row tabs:
And some multi-rows tabs:
Here is the HTML
For multi-row you can use
.multirows
.There is a huge room for improvement on the multi-rows html semantic. Currently each row requires its own
menu
.Coming next time :
Given i tried to reuse the
.window
as a tab container i had to find some hacks and made use of z-index in order to pull the active tab upfront and cover the container borders.Best 🙂