Python 2.6 & pycodestyle fix #149
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pip is not able to correctly manage constraints between invocations. Python 2.6 is currently failing because tox installs the packages in tox-requirements.txt and upgrades existing packages which were pinned in requirements.txt (i.e. attrs) In order to ensure the pinned versions are being tested, invoking pip once with all constraints loaded is the most reliable method.
Open
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
- Coverage 96.88% 96.57% -0.31%
==========================================
Files 14 14
Lines 1635 1635
==========================================
- Hits 1584 1579 -5
- Misses 51 56 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can see the Python 2.6 build errors on #150 .
And on all builds, you can see it is installing attrs 17, not attrs 15 as pinned in requirements.txt