$ref and fetching tree node from external source#720
Open
desertkun wants to merge 2 commits intojdorn:masterfrom
Open
$ref and fetching tree node from external source#720desertkun wants to merge 2 commits intojdorn:masterfrom
desertkun wants to merge 2 commits intojdorn:masterfrom
Conversation
Author
|
Fixes this issue #697 |
|
That's a great fix! Seems like there are some holes in handling $ref. Question: does your fork also handle relative $refs? I saw issue #544 which is having the same problem I'm having, but it hasn't been fixed. |
Author
|
Unfortunately, it does not. It just pulls "$ref": "https://example.com/schema.json#/subnode"is mentioned, and then iterates over tree to return |
|
can somebody please merge this? I need this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently, there were no way to fetch some part of external schema with
$ref. This pull request fixes this commit.{ "$ref": "http://example.com/path/schema.json#/node_a/subnode_b" }Also, this commit allows
enumSourceto use$ref:{ "type": "string", "enumSource": [{ "source": { "$ref": "http://example.com/path/schema.json#/items" }, "value": "{{item.id}}", "title": "Item <{{item.id}}>" }], }