-
Notifications
You must be signed in to change notification settings - Fork 0
chore: reorganize pyproject.toml structure and dependencies #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
pyproject.toml (2)
12-15
: Nice regrouping – consider addingSource
/Documentation
URLsPurely optional, but PyPI renders these extra links and improves UX.
35-37
: Remove empty[tool.uv.workspace]
blockAn empty workspace array adds noise and may confuse tooling. Unless you plan to populate it, drop the section:
-[tool.uv.workspace] -members = []
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pyproject.toml
(3 hunks)
🔇 Additional comments (3)
pyproject.toml (3)
16-18
: Build-system relocation looks correctSection now sits next to project metadata and still includes the required
hatch-vcs
. No further action.
63-64
:[tool.hatch.version]
correctly paired withhatch-vcs
Dynamic versioning via VCS is properly configured.
10-10
: Confirmaiohttp>=3.12.13
is installable
aiohttp
releases are still in the 3.9 series; a3.12.13
tag doesn’t exist on PyPI. An impossible lower-bound will break installs.#!/bin/bash # Show the highest published aiohttp versions curl -s https://pypi.org/pypi/aiohttp/json | jq -r '.releases | keys | sort | .[-10:]'If the version is absent, update to a realistic constraint (e.g.
aiohttp>=3.9,<4.0
).
Summary by CodeRabbit