-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve compatibility with Code-OSS #189
base: master
Are you sure you want to change the base?
Conversation
I added a note to the Readme for VSCode-OSS users. |
The extension already has |
I think having an explicit option to override the I managed to get the |
@getzze Hello, I am also looking for a way to use Remote-SSH in VSCode-OSS. I really appreciate you providing support in this area. May I ask when this commit is expected to be released? I would like to use it as soon as possible. |
I just tested on ArchLinux with the new update to 1.97.0 and it works perfectly: the release number is fetched automatically and the commit number is updated on the remote. I updated the README with the settings you need to change to make this plugin work with VSCode-OSS:
You have to change these settings just once, the future vscode-oss updates will be seamless. @GitMensch can you maybe review the PR now ? |
@getzze Great! I noticed that |
Sorry I didn't explain well, that's a new settings introduced in this PR, it's not merged yet.
|
@getzze Thank you so much! I can use it in VSCode-OSS after packaging it locally. |
solves: #163
The "release" part of the
version
is empty on Code-OSS, so the link to download VSCodium is wrong. Instead of having to modify the template url each time there is a new version of VSCode, this PR adds avscodiumReleaseNumber
setting to overwrite the release number (that can be found in the releases ).Also the
commit
value in theproduct.json
file on the remote host does not correspond to the Code-OSS commit, so it is updated with the correct value, to avoid a Version mismatch error.Tested on linux local and remote.
EDIT:
The "release" is now fetched automatically to the latest.
The
vscodiumReleaseNumber
is only needed if you need a specific release that is not the latest.VSCode-OSS users only need to modify the following plugin settings: