Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility with Code-OSS #189

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

getzze
Copy link

@getzze getzze commented Jan 22, 2025

solves: #163

The "release" part of the version is empty on Code-OSS, so the link to download VSCodium is wrong. Instead of having to modify the template url each time there is a new version of VSCode, this PR adds a vscodiumReleaseNumber setting to overwrite the release number (that can be found in the releases ).

Also the commit value in the product.json file on the remote host does not correspond to the Code-OSS commit, so it is updated with the correct value, to avoid a Version mismatch error.

Tested on linux local and remote.

EDIT:
The "release" is now fetched automatically to the latest.
The vscodiumReleaseNumber is only needed if you need a specific release that is not the latest.
VSCode-OSS users only need to modify the following plugin settings:

"remote.SSH.experimental.modifyMatchingCommit": true,
"remote.SSH.experimental.serverBinaryName": "codium-server",

@getzze
Copy link
Author

getzze commented Jan 23, 2025

I added a note to the Readme for VSCode-OSS users.

@jeanp413
Copy link
Owner

The extension already has remote.SSH.serverDownloadUrlTemplate, you can harcode the url and update it on each release, don't see why we need another setting

@getzze
Copy link
Author

getzze commented Jan 28, 2025

I think having an explicit option to override the release value is clearer. The remote.SSH.serverDownloadUrlTemplate is the general template that don't need to be modified (except if you want to use a fork of vscodium) and what you modify is the value injected in the template. Also because it's more error prone to modify the template than a field with only the release (it happened several time to me, so I decided to make this PR :))

I managed to get the release number automatically from the list of github releases (see commit 53bed51), so the installation process doesn't need user action anymore.

@emma03-work
Copy link

@getzze Hello, I am also looking for a way to use Remote-SSH in VSCode-OSS. I really appreciate you providing support in this area. May I ask when this commit is expected to be released? I would like to use it as soon as possible.

@getzze
Copy link
Author

getzze commented Feb 12, 2025

I just tested on ArchLinux with the new update to 1.97.0 and it works perfectly: the release number is fetched automatically and the commit number is updated on the remote.

I updated the README with the settings you need to change to make this plugin work with VSCode-OSS:

"remote.SSH.experimental.modifyMatchingCommit": true,
"remote.SSH.experimental.serverBinaryName": "codium-server",

You have to change these settings just once, the future vscode-oss updates will be seamless.

@GitMensch can you maybe review the PR now ?

@emma03-work
Copy link

@getzze Great! I noticed that modifyMatchingCommit is a newly added configuration. Currently, the Open Remote - SSH version 0.0.48 that I downloaded from Open VSX does not support it. Is there a beta version of the VSIX available? or how can I use it?

@getzze
Copy link
Author

getzze commented Feb 12, 2025

Sorry I didn't explain well, that's a new settings introduced in this PR, it's not merged yet.
The only way (that I know) to try the plugin with this PR is to build from source (you need to install vsce):

git clone -b compat-code-oss https://github.com/getzze/open-remote-ssh
cd open-remote-ssh
vsce package --yarn 
code --install-extension open-remote-ssh-0.0.48.vsix

@emma03-work
Copy link

@getzze Thank you so much! I can use it in VSCode-OSS after packaging it locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants