Use dir .. for shell detection on Windows instead of uname -s#240
Open
GilgameshxZero wants to merge 1 commit intojeanp413:masterfrom
Open
Use dir .. for shell detection on Windows instead of uname -s#240GilgameshxZero wants to merge 1 commit intojeanp413:masterfrom
dir .. for shell detection on Windows instead of uname -s#240GilgameshxZero wants to merge 1 commit intojeanp413:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the issue raised in #164 by updating how shell detection is performed on Windows.
dirhas demonstrable differences between its invocations inpowershell,cmd, and (git)bash, except on an empty directory...is likely non-empty, except in weird permissions/home directory scenarios.Another edge case which remains untested is that of different locales. I tried setting both system and user locales to
es-MXbut could not get a response inpowershell/cmdthat was not in English.Below are samples of
dir ..onpowershell,cmd, andbash.powershell:cmd:bash: