Skip to content

Comments

Fix trim() error when CurlHandle passed to log::add()#3151

Closed
brunetphilippe-prog wants to merge 1 commit intojeedom:4.5.3from
brunetphilippe-prog:master
Closed

Fix trim() error when CurlHandle passed to log::add()#3151
brunetphilippe-prog wants to merge 1 commit intojeedom:4.5.3from
brunetphilippe-prog:master

Conversation

@brunetphilippe-prog
Copy link

Prevent PHP Fatal Error when jsonrpcClient passes cURL handle instead of string to log::add(). Add type check before trim() call in log.class.php:112.

Description

Suggested changelog entry

Related issues/external references

Fixes #

Types of changes

  • Bug fix (non-breaking change which fixes)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

Prevent PHP Fatal Error when jsonrpcClient passes cURL handle instead of string to log::add().
Add type check before trim() call in log.class.php:112.
@Salvialf
Copy link
Contributor

Salvialf commented Dec 2, 2025

Hi @brunetphilippe-prog,

Sorry, but I don't understand what the problem is exactly ? $_message must be a string even from jsonRPC API .

Some more explanations are needed here.

@zoic21 zoic21 changed the base branch from master to 4.5.3 January 30, 2026 10:23
@zoic21
Copy link
Contributor

zoic21 commented Jan 30, 2026

Replace by PR #3189

@zoic21 zoic21 closed this Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants