Fix trim() error when CurlHandle passed to log::add()#3151
Closed
brunetphilippe-prog wants to merge 1 commit intojeedom:4.5.3from
Closed
Fix trim() error when CurlHandle passed to log::add()#3151brunetphilippe-prog wants to merge 1 commit intojeedom:4.5.3from
brunetphilippe-prog wants to merge 1 commit intojeedom:4.5.3from
Conversation
Prevent PHP Fatal Error when jsonrpcClient passes cURL handle instead of string to log::add(). Add type check before trim() call in log.class.php:112.
Contributor
|
Sorry, but I don't understand what the problem is exactly ? Some more explanations are needed here. |
kwizer15
approved these changes
Dec 2, 2025
zoic21
approved these changes
Jan 30, 2026
Merged
Contributor
|
Replace by PR #3189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent PHP Fatal Error when jsonrpcClient passes cURL handle instead of string to log::add(). Add type check before trim() call in log.class.php:112.
Description
Suggested changelog entry
Related issues/external references
Fixes #
Types of changes
PR checklist