Added check to see if the element has fixed position and use fixed po… #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sitioning for menu element
|
+1 |
|
I added a similar fix via PR #177 (I didn't see this before submitting). I've seen a few PRs attempting to solved the fixed element problem. @jeff-collins: thoughts on getting this into master soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the editable element is inside a element which is fixed, the menu appears either at the top or at a point above where it should ideally appear. This apparently is due to the fact that the cursor position calculation code returns a position relative to the top of the window (the target being fixed positioned), but when that position is applied to the absolutely positioned menu item, it ends up being positioned by that amount from the top of the page (as opposed to the window top), which results in the error.
It was fixed by seeing if the target element is fixed or inside a fixed parent, and if so, giving fixed position to the menu drop down.