Skip to content

fixing document click leak #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

dioxmio
Copy link

@dioxmio dioxmio commented Apr 14, 2016

$document events were never cleaned

@dioxmio
Copy link
Author

dioxmio commented Apr 14, 2016

the travis build is failing because of this:
bower ECONFLICT Unable to find suitable version for angular
can you fix that? the change is super simple and since my app is mobile I'll like to avoid any leaks :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.504% when pulling f7223a8 on dioxmio:master into ad2a0a9 on jeff-collins:master.

@dioxmio
Copy link
Author

dioxmio commented Apr 14, 2016

fixed it :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.504% when pulling 7f18136 on whitespectre:master into ad2a0a9 on jeff-collins:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-37.0%) to 42.339% when pulling cb22f17 on whitespectre:master into ad2a0a9 on jeff-collins:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 79.605% when pulling 367826d on whitespectre:master into ad2a0a9 on jeff-collins:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.572% when pulling 7da165d on whitespectre:master into ad2a0a9 on jeff-collins:master.

CGA-2094 - improvement on tagging UI/UX
@coveralls
Copy link

Coverage Status

Coverage decreased (-7.6%) to 71.704% when pulling f2eb455 on whitespectre:master into ad2a0a9 on jeff-collins:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.9%) to 71.474% when pulling 8f7b90a on whitespectre:master into ad2a0a9 on jeff-collins:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.9%) to 71.474% when pulling 2a57939 on whitespectre:master into ad2a0a9 on jeff-collins:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants