Change listItemImage background-size from cover to contain #7319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"cover" scales the picture to avoid empty space (even if some things are hidden). "contain" scales the picture to ensure all of it is visible (even if there's empty space).
Collaborator
Cloudflare Pages deployment
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently,
.listItemImagehasbackground-size: cover, which scales the picture to avoid empty space even if that hides part of the image. This can cause unwanted cropping:With this change, it has
background-size: contain, which scales the picture to ensure the entire image is visible, but may leave empty space around the image. This is how the same page looks with the change applied by (mis)using the "Custom CSS Code" in the server settings: