-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Tizen: Enable direct-play of anamorphic videos #7321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Cloudflare Pages deployment
|
src/scripts/browserDeviceProfile.js
Outdated
|
|
||
| function canDirectPlayAnamorphicVideo() { | ||
| // Tizen 9 applies the aspect ratio correctly | ||
| return browser.tizenVersion >= 9; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is supported in older versions too, but I'm only able to test a Tizen 9 device.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a QN95A, 2021 year, Tizen 6 afaict, and I'd love to be able to test this.
My tv had no issues direct playing without remuxing on 10.10.7. Can you point me towards a truehd enabled wgt to test with, I use the docker method from Georift for installing if that matters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't have a TrueHD-enabled build, but the .wgt in #7231 (comment) is hopefully enough to quickly test some anamorphic video.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to install it, but I couldn't. I have no idea how to install other than using the method above, and I think that is somewhat hardcoded to use jeppevinkel's builds. Pointing to your file locally just failed on me.
But would that even make sense to try, didn't you set tizen 9 as minimum version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But would that even make sense to try, didn't you set tizen 9 as minimum version?
Yeah it would, as I've changed the condition for that build to browser.tizen, specifically so that direct-play can be tested on all Tizen devices: kinke@efee821
FWIW, this is the script I'm using on Linux (incl. resigning the .wgt so that I can install it; had to create my own Samsung dev account... - edit: but I had to do that for jeppevinkel's builds too):
#!/usr/bin/env bash
set -euxo pipefail
tv_ip="192.168.178.20"
wgt="~/Downloads/Jellyfin.wgt"
# enable dev mode on TV, choosing *this* machine's IP, then reboot TV
curl -f http://$tv_ip:8001/api/v2/
~/tizen-studio/tools/sdb connect $tv_ip
# certificate creation: https://developer.samsung.com/smarttv/develop/getting-started/setting-up-sdk/creating-certificates.html
# then fix up `password`s in ~/tizen-studio-data/profile/profiles.xml
~/tizen-studio/tools/ide/bin/tizen package -t wgt -s MyProfile -- $wgt
# -t: see device name in `sdb devices` output
~/tizen-studio/tools/ide/bin/tizen install -n $wgt -t GQ65S95FATXZGThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, changed to tizenVersion >= 6.5 after successful tests: #7231 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I remembered that someone mentioned a one click installer made by PatrickSt1991, I found out that it could install a .wgt from a custom location, and after installing yours I can happily confirm that all my troublesome media plays beautifully, and your two example clips play just as well, this is on Tizen 6.0 on my 2021 65QN95A.
Thank you so much for your work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, changed to tizenVersion >= 6 accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, just wanted to give a heads up in regards to an issue with experimental pgs sub rendering using this version, the subs are out of sync if enabled. If I disable remuxing in the user settings and select "Always burn in subtitle when transcoding" they show up on time, but with poor quality AAC audio. Reverting back to the default 10.11.z branch fixes exp. pgs rendering, but breaks anamorphic shows as expected since your patch is not yet implemented.
EDIT: After more testing, I've found that even the normal branch has issues, and it was only by coincidence that the subtitles seemed to be working, they are in fact still broken.
|
Since this could be considered a bugfix for the broken remux playback, should this be targeting the 10.11 release branch? |
I can re-target obviously; I just can't confirm that this has actually regressed in v10.11 (as I haven't tested anamorphic videos with 10.10 earlier). These profile-conditions seem to be ancient (added around 5 years ago, for H264/H265 at least), so it didn't look like a regression to me, and I wasn't expecting direct-play to ever have worked. |
52c9b76 to
67621b8
Compare
Anamorphic videos currently require a remux, which apparently breaks the aspect ratio: jellyfin/jellyfin-tizen#376 On my Tizen v9 TV, the web player handles the aspect ratio just fine directly, correctly stretching the 720x472 pixels of some DVD source to a 873x472 view. Tested with HEVC and H264 media. Also got successful test reports on Tizen 6.0 and 6.5 TVs.
67621b8 to
a00e8dc
Compare
|



Anamorphic videos currently require a remux, which apparently breaks the aspect ratio: jellyfin/jellyfin-tizen#376
On my Tizen v9 TV, the web player handles the aspect ratio just fine directly, correctly stretching the 720x472 pixels of some DVD source to a 873x472 view. Edit: Tested with HEVC and H264 media.