-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Support DOVI in mkv container on WebOS 25 and newer #7328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Cloudflare Pages deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint doesn't pass. Please fix all ESLint issues.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
I built your PR and ran it together with Jellyfin 10.11.2. On the CX TV, this pr forces the EAC3 in P8 MKV files to transcode to AAC, but it does not work in remuxing mode. |
|
AFAIK, DoVi in MKV was denied because DoVi Profile 5 was played with incorrect colors - #4916 Is DoVi Profile 5 in MKV now playing with the correct colors? |
This PR can activate Dolby Vision for p8 MKV on webOS as long as you set Prefer fMP4-HLS Media Container: enable; otherwise, it will be HDR. P5 MP4 can work in direct play mode while also enabling Dolby Vision on tv. I currently don't have a sample for P5 MKV, so it hasn't been tested.
Additionally, I personally think that the PR that solves the CX subtitle desynchronization issue is 'Add option to limit HLS segment length for webOS (#6530). As long as Use shorter HLS segments: enable, which means hls_time=1, it can fix the desynchronization on CX. This applies to both fMP4 and TS containers.When I use your PR with 'Use shorter HLS segments: disable,' I still encounter the issue of subtitles being out of sync. tv cx |
This should not change anything on CX, it shoud work the same as before. When testing, make sure you enable Prefer fMP4-HLS container on 10.11.2 because it uses HLS.js so it needs to remux to mp4 container for DV to work. If you test this with 10.10.7, make sure to disable Prefer fMP4-HLS container because it uses native hls so it needs to remux to ts container which is more stable.
This was the case until WebOS 25, now we do have support for DOVI in MKV container. |
|



This change enables Direct Play of DOVI files in MKV container on WebOS 25, while still blocking it on earlier versions that do not support it, allowing remuxing on C1, CX and other devices that won't receive the latest update.
LG’s internal player is still far from perfect, but it is improving. A recent software update (version 33.22.52) fixed the stuttering issue I experienced when playing MKV files with many embedded subtitles on earlier version 33.22.15 (tested on an LG C2). Since the update, I haven’t encountered any other issues when directly playing MKV files with DOVI, so this might be a good time to merge the change.
Seeking forward and backward now works much better compared to remuxing to TS or MP4 containers. I also haven’t been able to get subtitles out of sync like I could before. This change may fix other issues like audio passthrough problems that I'm unable to test myself.