Refactor light theme to use base theme #7347
Open
+128
−520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Cloudflare Pages deployment
|
thornbill
force-pushed
the
base-theme-light
branch
from
e9168a2 to
d9d44c4
Compare
Member
|
The dropdown to select theme (and other things) is white in all themes |
|
Member
Author
The only theme using the new base theme is the dark (and light with this PR) themes. It was an issue in the dark theme though. Styling for native select elements is pretty poorly supported so the best I could do was use a slightly different (non-transparent) color for them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Refactors the light theme to extend the base theme. There should only be minor differences in the appearance. The most significant being the header is lighter which was already the case in the experimental layout.
Issues
N/A