Add Studios tab and filter to Movies library #7355
Open
+170
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Studios tab to Movies library (similar to Networks tab in TV Shows) - Add Studios filter option to Movie Library filter dialog - Create moviestudios.js controller to display studios in card grid - Add Studios to LibraryTab enum - Hide favorite button on Studio items (canRate now excludes Studio type) - Studios filter uses comma-delimited GUIDs matching API requirements
Collaborator
Cloudflare Pages deployment
|
- Extract shared studios controller logic into studiosController.js - Update moviestudios.js and tvstudios.js to use shared controller - Reduces duplication from 60% to near zero for moviestudios.js - Add comment explaining acceptable duplication in moviesrecommended.js tab management
- Replace getAttribute('data-filter') with dataset.filter in filterdialog.js (2 instances)
- Fix duplicate id 'items' by renaming to 'studioItems' in movies.html and tvrecommended.html
- Name the controller function StudiosController to address unnamed function warning
- Remove 'self' assignment pattern, use 'this' directly in constructor
- Remove backward compatibility fallback, use #studioItems selector consistently
|
Member
|
@bluesam1 FYI the experimental view will become the default for mobile and desktop in the next release. This pull request is probably fine but it won't affect the new views. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Studio filtering and browsing capabilities to the Movies library, bringing feature parity with TV Shows' Networks functionality.
Changes
Studios Filter in Filter Dialog
Studios Tab in Movies Library
StudiostoLibraryTabenumBug Fix
canRate()function to excludeStudiotypeTechnical Details
New Files:
src/controllers/movies/moviestudios.js- Controller for Studios tabModified Files:
src/components/filterdialog/filterdialog.js- Added studios filter logicsrc/components/filterdialog/filterdialog.template.html- Added Studios UI sectionsrc/controllers/movies/movies.html- Added Studios tab HTMLsrc/controllers/movies/moviesrecommended.js- Added Studios tab routingsrc/types/libraryTab.ts- AddedStudiosenum valuesrc/components/itemHelper.js- Excluded Studio fromcanRate()Backend Support
No backend changes required. The API already supports
StudioIdsparameter in/Users/{UserId}/Itemsendpoint.Testing
Related
Addresses the feature request to add Studio filtering to Movie Library, providing consistency with TV Shows' Networks functionality.