Fix media session isLocalPlayer detection on first player change #7360
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlaybackSubscriber was firing media session updates before rebinding the new player, so the initial payload sent `isLocalPlayer: false` (player undefined) to NativeShell. Android then assumed remote playback and showed the cast/remote volume rocker instead of the phone’s local volume, making volume control cumbersome. Use the current playbackManager player as a fallback and set `this.player` on playerchange before emitting the first update to restore correct isLocalPlayer reporting. Fixes: jellyfin/jellyfin-android#1745 Fixes: jellyfin/jellyfin-android#1854
Collaborator
Cloudflare Pages deployment
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PlaybackSubscriber was firing media session updates before rebinding the new player, so the initial payload sent
isLocalPlayer: false(player undefined) to NativeShell. Android then assumed remote playback and showed the cast/remote volume rocker instead of the phone’s local volume, making volume control cumbersome. Use the current playbackManager player as a fallback and setthis.playeron playerchange before emitting the first update to restore correct isLocalPlayer reporting.Issues
Fixes: jellyfin/jellyfin-android#1745
Fixes: jellyfin/jellyfin-android#1854