-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ASDF version to 0.16.2 #278
Open
jenkins-infra-updatecli
wants to merge
4
commits into
main
Choose a base branch
from
updatecli_main_e0be5a2176a98f45ca26bc7029fbf8f581cfd6b980bd1e17af589ebf7834d10c
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bump ASDF version to 0.16.2 #278
jenkins-infra-updatecli
wants to merge
4
commits into
main
from
updatecli_main_e0be5a2176a98f45ca26bc7029fbf8f581cfd6b980bd1e17af589ebf7834d10c
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a9b2781
to
735552d
Compare
dduportal
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a breaking change which needs careful testing: https://github.com/asdf-vm/asdf/releases/tag/v0.16.0. See also jenkins-infra/packer-images#1706 (review)
c5ac27f
to
df24e65
Compare
Made with ❤️️ by updatecli
... st harness Made with ❤️️ by updatecli
ec75e4c
to
f6b7874
Compare
Made with ❤️️ by updatecli
... st harness Made with ❤️️ by updatecli
gounthar
approved these changes
Feb 15, 2025
This PR is not working as expected. ASDF installation is broken compared to 0.15.x and it needs rework |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the ASDF version
Update the value of ARG ASDF_VERSION in the Dockerfile
changed lines [128] of file "/tmp/updatecli/github/jenkins-infra/docker-builder/Dockerfile"
0.16.1
0.16.2
Update the label io.jenkins-infra.tools.asdf.version in the test harness
change detected: * key "$.metadataTest.labels[4].value" updated from "0.16.1" to "0.16.2", in file "cst.yml"
0.16.1
0.16.2
Created automatically by Updatecli
Options:
Most of Updatecli configuration is done via its manifest(s).
Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!