Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Probot-Autolabeler configuration for documentation #101

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

biru-codeastromer
Copy link
Contributor

@biru-codeastromer biru-codeastromer commented Feb 15, 2025

Fixes #100

Description :

  • This PR introduces a configuration file for Probot-Autolabeler to automate labeling of Pull Requests related to documentation updates.

Key Details:

  • The documentation label is applied to PRs that modify:
  1. README.md file .
  2. All yaml files .

Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @biru-codeastromer the format seems incorrect, could you please follow the one in https://github.com/jenkins-infra/jenkins.io/blob/master/.github/autolabeler.yml?

@@ -0,0 +1,3 @@
documentation:
- README.md
- src/user-story/**/*.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we including this:

- src/user-story/**/*.yaml

Why should changes to these files be considered changes in documentation?

Copy link
Contributor Author

@biru-codeastromer biru-codeastromer Feb 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir I thought the .yaml files under src/user-story/ define structured user stories Therefore, changes to these files will align with documentation updates.

What's your view on this do you think it is valid ? Let me know if it's not required here .

Copy link
Member

@krisstern krisstern Feb 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The src/user-story/**/*.yaml contain the actual contents of the featured stories, not documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the clarification thanks. Sure , I am removing now .

@krisstern krisstern changed the title add Probot-Autolabeler configuration for documentation label feat: add Probot-Autolabeler configuration for documentation Feb 15, 2025
@biru-codeastromer
Copy link
Contributor Author

I have removed the .yaml files from the documentation label . Thanks !

Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krisstern krisstern merged commit 9688920 into jenkins-infra:main Feb 16, 2025
7 checks passed
@biru-codeastromer biru-codeastromer deleted the autoprobot branch February 16, 2025 05:41
@biru-codeastromer
Copy link
Contributor Author

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Probot-Autolabeler bot to automate some PR labelings
2 participants