Skip to content

JENKINS-75593: Use empty string for undefined referencedParameters #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asc3ns10n
Copy link

The change in #467 has caused parameters without referenced parameters to no longer render correctly in certain conditions:

  1. Reactive Reference Parameter set as Hidden HTML is not being hidden (JENKINS-75593)
  2. Filtering for Reactive Parameter doesn't function (JENKINS-75660)

While it seems uncommon to use a Reactive Parameter without references, I rely on Reactive Reference parameters with no references for hidden values or to trigger custom JavaScript.

The undefined errors seem to only occur in pipelines. In freestyle jobs the value is an empty string if there are no referenced parameters. I'm thinking it should default to an empty string in both cases. This would maintain consistency between job types and prevent JS errors when accessing the referencedParameters property.

I can add some tests if this is an acceptable solution.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@asc3ns10n asc3ns10n requested a review from a team as a code owner May 23, 2025 01:09
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, @asc3ns10n . I will have to check if this was disabled to prevent a bug... but if not we can merge it once the tests are fixed. I can fix them when I have time, or if you can fix them and get a green build here I might be able to quickly review and release soon. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants