-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Github App Credentials support #186
base: master
Are you sure you want to change the base?
Conversation
6cff667
to
008c411
Compare
f950dc2
to
3843dd5
Compare
it would be awesome to get this one merged, is there anything that's missing? I can try to help if so |
Looks like there are some conflicts now due to changes from v1.2.0. Once this is integrated and tested we need 👀 from the maintainers. |
Hey I would also add my help here to get this one merged and released :) |
Hello, do you have ETA? |
@trispad, we could really do with making us of those one, let me know if there's anything I can do to help get this over the line, it looks like it's nearly there! |
@tomcart90 - What would be helpful is re-integrating this with the mainline. There were some changes made to main that need to be addressed in this PR. If you could do it I would be appreciative. |
Guys, any progress with that? |
hello team, also would like to know, any updates? |
@trispad is this not merged because there are still errors? |
@jon-schuck-MA added support for Github App Credentials from the github-branch-source plugin. The github-branch-source plugin is optional and the credentials will only will be created when the plugin is installed.
I am attempting to take their work from #87 to done.