Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Github App Credentials support #186

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

trispad
Copy link

@trispad trispad commented Mar 3, 2022

@jon-schuck-MA added support for Github App Credentials from the github-branch-source plugin. The github-branch-source plugin is optional and the credentials will only will be created when the plugin is installed.

I am attempting to take their work from #87 to done.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@trispad trispad marked this pull request as ready for review March 4, 2022 20:49
@julio-je-yaguez
Copy link

it would be awesome to get this one merged, is there anything that's missing? I can try to help if so

@trispad
Copy link
Author

trispad commented Jul 5, 2022

Looks like there are some conflicts now due to changes from v1.2.0. Once this is integrated and tested we need 👀 from the maintainers.

@Larusso
Copy link

Larusso commented Aug 31, 2022

Hey I would also add my help here to get this one merged and released :)

@denis-matchenko
Copy link

Hello, do you have ETA?

@tomcart90
Copy link

@trispad, we could really do with making us of those one, let me know if there's anything I can do to help get this over the line, it looks like it's nearly there!

@trispad
Copy link
Author

trispad commented Jul 17, 2023

@tomcart90 - What would be helpful is re-integrating this with the mainline. There were some changes made to main that need to be addressed in this PR. If you could do it I would be appreciative.

@asaf-the-ancient
Copy link

Guys, any progress with that?

@nickhuang016
Copy link

hello team, also would like to know, any updates?

@jkerrigan-chwy
Copy link

@trispad is this not merged because there are still errors?
@chriskilding has this been reviewed by you or fellow owners?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants