[JENKINS-75203] Include parent in build status notification #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...com/cloudbees/jenkins/plugins/bitbucket/impl/notifier/BitbucketBuildStatusNotifications.java
Outdated
Show resolved
Hide resolved
nfalco79
requested changes
Mar 12, 2025
src/main/java/com/cloudbees/jenkins/plugins/bitbucket/api/BitbucketBuildStatus.java
Outdated
Show resolved
Hide resolved
...com/cloudbees/jenkins/plugins/bitbucket/impl/notifier/BitbucketBuildStatusNotifications.java
Outdated
Show resolved
Hide resolved
...com/cloudbees/jenkins/plugins/bitbucket/impl/notifier/BitbucketBuildStatusNotifications.java
Outdated
Show resolved
Hide resolved
...com/cloudbees/jenkins/plugins/bitbucket/impl/notifier/BitbucketBuildStatusNotifications.java
Show resolved
Hide resolved
nfalco79
approved these changes
Mar 14, 2025
|
@ugrave I need you squash commits using as first line the issue title and change the target branch 935.1.x |
nfalco79
reviewed
Mar 14, 2025
...ees/jenkins/plugins/bitbucket/impl/notifier/BitbucketBuildStatusNotificationsJUnit5Test.java
Outdated
Show resolved
Hide resolved
ugrave
force-pushed
the
include-parent-in-build-status
branch
from
19b7ea5 to
02f1c66
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| return response; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public interface IRequestAudit { | ||
| default void request(HttpRequest request) { |
Check notice
Code scanning / CodeQL
Useless parameter
ugrave
force-pushed
the
include-parent-in-build-status
branch
from
02f1c66 to
941a84a
Compare
Squashed and changed the target branch |
nfalco79
pushed a commit
that referenced
this pull request
Mar 14, 2025
…atus with parent attribute valued (#1004) Sets the parent attribute when sending a build status notification to Bitbucket Data Center. This makes the "Requested Builds" merge checks work. If the parent (of each build status) is not valued, key filtering is not possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include parent key into build status notification to be abler to use the required build feature in bitbucket
The parent key is calculated from the parent of the build.
https://issues.jenkins.io/browse/JENKINS-75203
Your checklist for this pull request