Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-75203] Include parent in build status notification #1004

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

ugrave
Copy link
Contributor

@ugrave ugrave commented Mar 12, 2025

Include parent key into build status notification to be abler to use the required build feature in bitbucket

The parent key is calculated from the parent of the build.

https://issues.jenkins.io/browse/JENKINS-75203

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

@nfalco79 nfalco79 changed the base branch from master to 935.1.x March 14, 2025 15:44
@nfalco79 nfalco79 changed the base branch from 935.1.x to master March 14, 2025 15:44
@nfalco79
Copy link
Member

@ugrave I need you squash commits using as first line the issue title and change the target branch 935.1.x

@ugrave ugrave force-pushed the include-parent-in-build-status branch from 19b7ea5 to 02f1c66 Compare March 14, 2025 16:19
@ugrave ugrave changed the base branch from master to 935.1.x March 14, 2025 16:21

return response;
}
}
}

public interface IRequestAudit {
default void request(HttpRequest request) {

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'request' is never used.
@ugrave ugrave changed the base branch from 935.1.x to master March 14, 2025 16:23
@ugrave ugrave force-pushed the include-parent-in-build-status branch from 02f1c66 to 941a84a Compare March 14, 2025 16:32
@ugrave ugrave changed the base branch from master to 935.1.x March 14, 2025 16:32
@ugrave
Copy link
Contributor Author

ugrave commented Mar 14, 2025

@ugrave I need you squash commits using as first line the issue title and change the target branch 935.1.x

Squashed and changed the target branch

@nfalco79 nfalco79 merged commit 60555a8 into jenkinsci:935.1.x Mar 14, 2025
15 checks passed
nfalco79 pushed a commit that referenced this pull request Mar 14, 2025
…atus with parent attribute valued (#1004)

Sets the parent attribute when sending a build status notification to Bitbucket Data Center. This makes the "Requested Builds" merge checks work. If the parent (of each build status) is not valued, key filtering is not possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants