-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-75410] extends AbstractGitSCMSource for BitbucketSCMSource #1006
base: 935.1.x
Are you sure you want to change the base?
Conversation
…nd implement getRemote()
scmSource.getServerUrl(), | ||
scmSource.getOwner(), | ||
BitbucketSCMSource.DescriptorImpl.SAME.equals( | ||
scmSource.getCheckoutCredentialsId()) ? credentialsId : |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
BitbucketSCMSource.getCheckoutCredentialsId
scmSource.getOwner(), | ||
BitbucketSCMSource.DescriptorImpl.SAME.equals( | ||
scmSource.getCheckoutCredentialsId()) ? credentialsId : | ||
scmSource.getCheckoutCredentialsId(), |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
BitbucketSCMSource.getCheckoutCredentialsId
Which is this exception? Why the "Multibranch build strategy extension" does not use the interface API instead of the abstract class? |
The exception is a ClassCastException because on this line when calling the build method the I also try to change the code in other plugin to get the |
See JENKINS-49417. |
Ok, I understand your point. Thanks |
Change BitbucketSCMSource extended class to AbstractGitSCMSource to be fully compatible with Pipeline: Multibranch build strategy extension.
Otherwise the srategy extension plugin throws an exception when trying to get the changeset to apply the strategy defined in the job.
Your checklist for this pull request