Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Remove jenkinsci/jacoco-plugin#291 workaround #3921 #3943

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Fixes Remove jenkinsci/jacoco-plugin#291 workaround #3921 #3943

merged 1 commit into from
Nov 10, 2024

Conversation

darinpope
Copy link
Contributor

@darinpope darinpope commented Nov 10, 2024 •
edited by basil
Loading

Reverting the exclusions after release of jacoco 3.3.7

Testing done

  • LINE=2.452.x PLUGINS=jacoco bash local-test.sh
  • LINE=2.462.x PLUGINS=jacoco bash local-test.sh
  • LINE=2.479.x PLUGINS=jacoco bash local-test.sh
  • LINE=weekly PLUGINS=jacoco bash local-test.sh

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Fixes #3921

@darinpope darinpope requested a review from a team as a code owner November 10, 2024 12:09
@darinpope darinpope added the full-test Test all LTS lines in this PR and do not halt upon first error. label Nov 10, 2024
basil
basil approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@basil basil added the tests label Nov 10, 2024
@basil basil merged commit d06ec1f into jenkinsci:master Nov 10, 2024
829 of 832 checks passed
@darinpope darinpope deleted the fix-3912 branch November 11, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

Assignees
No one assigned
Labels
full-test Test all LTS lines in this PR and do not halt upon first error. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove jenkinsci/jacoco-plugin#291 workaround
2 participants
@darinpope @basil