Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-73962] Extract event handlers in LegacyTagAction/tagForm.jelly #106

Merged
merged 9 commits into from
Oct 22, 2024
Merged

[JENKINS-73962] Extract event handlers in LegacyTagAction/tagForm.jelly #106

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
26a3d12
extract JS in tagform.jelly
shlomomdahan Oct 21, 2024
3bf9f64
Merge branch 'master' into JENKINS-73962
shlomomdahan Oct 21, 2024
ccaf36b
address comments
shlomomdahan Oct 22, 2024
7b87dbc
Merge remote-tracking branch 'origin/JENKINS-73962' into JENKINS-73962
shlomomdahan Oct 22, 2024
8de118c
address comments
shlomomdahan Oct 22, 2024
a0a8134
remove unnecessary id
shlomomdahan Oct 22, 2024
244f89e
Merge branch 'master' into JENKINS-73962
basil Oct 22, 2024
41e35f8
Consistent formatting with other PRs
basil Oct 22, 2024
019cf07
Consistent formatting with code before this PR and with code two line…
basil Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/resources/hudson/scm/cvstagging/LegacyTagAction/create-another-tag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
ocument.addEventListener('DOMContentLoaded', () => {
shlomomdahan marked this conversation as resolved.
Show resolved Hide resolved

document.getElementById('create-another-tag-button')
.addEventListener('click', () => {
document.getElementById('tagForm').show();
document.getElementById('tagButton').style.display = 'none';
});
});
4 changes: 2 additions & 2 deletions src/main/resources/hudson/scm/cvstagging/LegacyTagAction/tagForm.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@ THE SOFTWARE.
</j:forEach>
</p>

<st:adjunct includes="hudson.scm.cvstagging.LegacyTagAction.create-another-tag"/>
shlomomdahan marked this conversation as resolved.
Show resolved Hide resolved
<j:if test="${h.hasPermission(it.build,it.permission)}">
<p id="tagButton">
<input type="button" value="${%Create another tag}"
onclick="Element.show('tagForm');Element.hide('tagButton')"/>
<input type="button" value="${%Create another tag}" id="create-another-tag-button" />
</p>

<div id="tagForm" style="display:none;">
Expand Down
Loading