Skip to content

Migrate tests to JUnit5 #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2025
Merged

Migrate tests to JUnit5 #1130

merged 1 commit into from
Feb 5, 2025

Conversation

strangelookingnerd
Copy link
Contributor

This PR aims to migrate all tests to JUnit5. Changes include:

  • Migrate annotations
  • Migrate assertions
  • Cleanup assertions
  • Migrate assumptions
  • Minor cleanup
  • Remove public visibility of test classes and methods

I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewd.
If there are any questions, please do not hesitate to ping me.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd
Migrate tests to JUnit5
80a0d39 
* Migrate annotations
* Migrate assertions
* Cleanup assertions
* Migrate assumptions
* Minor cleanup
* Remove public visibility of test classes and methods
@strangelookingnerd strangelookingnerd requested a review from a team as a code owner February 5, 2025 16:31
MarkEWaite
MarkEWaite approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite added the test Add or improve tests or test infrastructure label Feb 5, 2025
@MarkEWaite MarkEWaite merged commit 04a8956 into jenkinsci:master Feb 5, 2025
17 checks passed
@strangelookingnerd strangelookingnerd deleted the migrate_to_junit5 branch February 5, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees

No one assigned

Labels

test Add or improve tests or test infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@strangelookingnerd @MarkEWaite