Skip to content

Avoid excessive Closures #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

Avoid excessive Closures #1131

merged 1 commit into from
Feb 25, 2025

Conversation

jglick
Copy link
Member

@jglick jglick commented Feb 25, 2025

@jglick jglick requested a review from a team as a code owner February 25, 2025 19:01
jglick
jglick commented Feb 25, 2025
View reviewed changes
src/main/resources/io/jenkins/docker/pipeline/DockerAgentScript.groovy
script.getProperty("currentBuild").result = Utils.getResultFromException(e)
throw e
void run(Closure body) {
try {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ignore whitespace)

@MarkEWaite MarkEWaite added RFE A Request for Enhancement. Usually linked to a PR that follows it. feature a PR providing a new feature. and removed RFE A Request for Enhancement. Usually linked to a PR that follows it. labels Feb 25, 2025
MarkEWaite
MarkEWaite approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've tested it in my relatively simple environment and confirmed that my declarative Pipeline samples work as expected. They launch a container agent through the incremental of this change and report no error.

@MarkEWaite MarkEWaite merged commit bdb55a8 into jenkinsci:master Feb 25, 2025
17 checks passed
@jglick jglick mentioned this pull request Mar 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees

No one assigned

Labels

feature a PR providing a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jglick @MarkEWaite