Adding HostConfig to ContainerConfig to fix Bind Volumes #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrectly in docker 1.4
|
Ok - I'm trying to merge in the move to docker-java/docker-java, I'll try this patch when that's done + merge. |
magnayn
added a commit
that referenced
this pull request
Jan 20, 2015
Adding HostConfig to ContainerConfig to fix Bind Volumes
|
Ok - I've merged back to docker-java, I'm not sure if it's configuration also requires items from createHostConfig into createContainerConfig -- could you take a look if you have a 1.4 host? |
|
i tested it against: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as to the docker API documentation (1.16) the HostConfig part of the create container call is used to setup a container with bind volumes (binding a host dir to a container dir). As of now the HostConfig is only passed into the start container call (in which it get discarded in docker 1.4).
this needs nirima/jDocker#5