Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install git-lfs from tar.gz instead of packagecloud #1954

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

MarkEWaite
Copy link
Contributor

Install git-lfs from tar.gz instead of packagecloud

Install fails from packagecloud on one or more of the required platforms

Use tar.gz for Debian because it is not available from packagecloud.

Fixes #1953

Testing done

Confirmed that the container builds complete successfully and that the git lfs version output reports 3.6.0 as expected.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Install fails from packagecloud on one or more of the required platforms

Use tar.gz for Debian because it is not available from packagecloud.

Fixes jenkinsci#1953
@MarkEWaite MarkEWaite requested a review from a team as a code owner November 26, 2024 04:55
@MarkEWaite MarkEWaite added the bug label Nov 26, 2024
Copy link
Contributor

@lemeurherveCB lemeurherveCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to put git-lfs version as ARG and add double quotes around the URL to avoid ignoring SC2086.

debian/bookworm-slim/hotspot/Dockerfile Outdated Show resolved Hide resolved
debian/bookworm/hotspot/Dockerfile Outdated Show resolved Hide resolved
@lemeurherveCB
Copy link
Contributor

lemeurherveCB commented Nov 26, 2024

Suggested corresponding updatecli manifest (can be added later):

./updatecli/updatecli.d/git-lfs.yaml
---
name: Bump git-lfs version

scms:
  default:
    kind: github
    spec:
      user: "{{ .github.user }}"
      email: "{{ .github.email }}"
      owner: "{{ .github.owner }}"
      repository: "{{ .github.repository }}"
      token: "{{ requiredEnv .github.token }}"
      username: "{{ .github.username }}"
      branch: "{{ .github.branch }}"

sources:
  lastReleaseVersion:
    kind: githubrelease
    name: Get the latest git-lfs release version
    spec:
      owner: "git-lfs"
      repository: "git-lfs"
      token: "{{ requiredEnv .github.token }}"
      username: "{{ .github.username }}"
      versionfilter:
        kind: semver
    transformers:
      - trimprefix: v

targets:
  updateVersion:
    name: "Update `git-lfs` version in debian dockerfiles"
    sourceid: lastReleaseVersion
    kind: dockerfile
    spec:
      files:
        - "debian/bookworm/hotspot/Dockerfile"
        - "debian/bookworm/hotspot/Dockerfile"
      instruction:
        keyword: "ARG"
        matcher: "GIT_LFS_VERSION"
    scmid: default

actions:
  default:
    kind: github/pullrequest
    title: Bump `git-lfs` version to {{ source "lastReleaseVersion" }}
    scmid: default
    spec:
      labels:
        - dependencies
        - git-lfs

@dduportal dduportal enabled auto-merge November 26, 2024 11:08
@dduportal dduportal merged commit 189fbe4 into jenkinsci:master Nov 26, 2024
11 of 12 checks passed
@MarkEWaite MarkEWaite deleted the remove-debian-git-lfs branch November 26, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container build fails because ppc64le Debian git-lfs not available from packagecloud
3 participants