Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updatecli): Uses the native temurin source #1957

Merged
merged 19 commits into from
Nov 27, 2024

Conversation

gounthar
Copy link
Contributor

@gounthar gounthar commented Nov 27, 2024

  • Enhanced JDK version bumping configurations for JDK 17 and JDK 21 thanks to the native temurin source
  • Removed outdated script for JDK verification to streamline processes.

Testing done

updatecli diff --debug --config ./updatecli/updatecli.d/jdk17.yaml --values ./updatecli/values.github-action.yaml 2>&1
updatecli diff --debug --config ./updatecli/updatecli.d/jdk21.yaml --values ./updatecli/values.github-action.yaml 2>&1

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gounthar gounthar requested a review from a team as a code owner November 27, 2024 08:48
@gounthar
Copy link
Contributor Author

jenkinsci.docker.alpine_jdk17.Default.#7 [alpine_jdk17-plugins-cli] do not upgrade if plugin has been manually updated

fails, but this has nothing to do with the proposed changes. #1958 fails the same way with different file changes. 🤷

Copy link
Contributor

@lemeurherveCB lemeurherveCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Too many obvious comments not adding any value though, and the replacer to review, having it on the source once avoid repeting it on most of the targets.

updatecli/updatecli.d/jdk17.yaml Outdated Show resolved Hide resolved
updatecli/updatecli.d/jdk17.yaml Outdated Show resolved Hide resolved
updatecli/updatecli.d/jdk17.yaml Outdated Show resolved Hide resolved
updatecli/updatecli.d/jdk17.yaml Outdated Show resolved Hide resolved
updatecli/updatecli.d/jdk17.yaml Outdated Show resolved Hide resolved
updatecli/updatecli.d/jdk17.yaml Show resolved Hide resolved
updatecli/updatecli.d/jdk17.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remarks as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I will modify it accordingly.
Thanks for the review, folks!

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Bump JDK17 version:
	Source:
		✔ [lastVersion] Get the latest Adoptium JDK17 version
	Condition:
		✔ [checkTemurinAllReleases] Check if the "<lastVersion>" is available for all platforms
	Target:
		✔ [setJDK17VersionAlpine] Bump JDK17 version for Linux images in the Alpine Linux Dockerfile
		✔ [setJDK17VersionDebian] Bump JDK17 version for Linux images in the Debian Dockerfiles
		✔ [setJDK17VersionDockerBake] Bump JDK17 version for Linux images in the docker-bake.hcl file
		✔ [setJDK17VersionRhel] Bump JDK17 version for Linux images in the Rhel Dockerfile
		✔ [setJDK17VersionWindowsDockerCompose] Bump JDK17 version in build-windows.yaml
		✔ [setJDK17VersionWindowsDockerImage] Bump default JDK17 version for Linux images in the Windows Dockerfile


✔ Bump JDK21 version:
	Source:
		✔ [lastTemurin21Version] Get the latest Adoptium JDK21 version via the API
	Condition:
		✔ [checkTemurinAllReleases] Check if the "<lastTemurin21Version>" is available for all platforms
	Target:
		✔ [setJDK21VersionDockerBake] Bump JDK21 version for Linux images in the docker-bake.hcl file
		✔ [setJDK21VersionWindowsDockerCompose] Bump JDK21 version in build-windows.yaml

LGTM!

@dduportal dduportal enabled auto-merge November 27, 2024 13:47
@dduportal dduportal disabled auto-merge November 27, 2024 13:47
@dduportal dduportal merged commit 6f43191 into jenkinsci:master Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants