-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(updatecli): Uses the native temurin source #1957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Too many obvious comments not adding any value though, and the replacer to review, having it on the source once avoid repeting it on most of the targets.
updatecli/updatecli.d/jdk21.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same remarks as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I will modify it accordingly.
Thanks for the review, folks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔ Bump JDK17 version:
Source:
✔ [lastVersion] Get the latest Adoptium JDK17 version
Condition:
✔ [checkTemurinAllReleases] Check if the "<lastVersion>" is available for all platforms
Target:
✔ [setJDK17VersionAlpine] Bump JDK17 version for Linux images in the Alpine Linux Dockerfile
✔ [setJDK17VersionDebian] Bump JDK17 version for Linux images in the Debian Dockerfiles
✔ [setJDK17VersionDockerBake] Bump JDK17 version for Linux images in the docker-bake.hcl file
✔ [setJDK17VersionRhel] Bump JDK17 version for Linux images in the Rhel Dockerfile
✔ [setJDK17VersionWindowsDockerCompose] Bump JDK17 version in build-windows.yaml
✔ [setJDK17VersionWindowsDockerImage] Bump default JDK17 version for Linux images in the Windows Dockerfile
✔ Bump JDK21 version:
Source:
✔ [lastTemurin21Version] Get the latest Adoptium JDK21 version via the API
Condition:
✔ [checkTemurinAllReleases] Check if the "<lastTemurin21Version>" is available for all platforms
Target:
✔ [setJDK21VersionDockerBake] Bump JDK21 version for Linux images in the docker-bake.hcl file
✔ [setJDK21VersionWindowsDockerCompose] Bump JDK21 version in build-windows.yaml
LGTM!
Testing done
Submitter checklist