Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74775] Remove unnecessary template strings in render-configurable-trend-chart.js #360

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

yaroslavafenkin
Copy link
Contributor

https://issues.jenkins.io/browse/JENKINS-74775

Testing done

Followed the instructions in https://issues.jenkins.io/browse/JENKINS-74775?focusedId=450147&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-450147.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@yaroslavafenkin yaroslavafenkin changed the title [JENKINS-74775] Remove unnecessary string literals in render-configurable-trend-chart.js [JENKINS-74775] Remove unnecessary template strings in render-configurable-trend-chart.js Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.42%. Comparing base (672c83e) to head (041c4d4).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #360   +/-   ##
=========================================
  Coverage     51.42%   51.42%           
  Complexity       17       17           
=========================================
  Files             7        7           
  Lines           105      105           
  Branches          3        3           
=========================================
  Hits             54       54           
  Misses           51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner added the bug Bugs or performance problems label Oct 28, 2024
@uhafner
Copy link
Member

uhafner commented Oct 28, 2024

Thanks for fixing.

@uhafner uhafner merged commit b2a594c into jenkinsci:main Oct 28, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants