Use core default driver for XStream #1390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XStream default driver (based on XML Pull Parser 3rd edition) is one that core no longer prefers or uses for various reasons, including bugs parsing emoji in modern XML files. Instead core now uses the Streaming API for XML (StAX) that is built into modern versions of the Java Platform runtime environment. I have been working to slowly remove the old XPP3 parser from core, but I discovered that this plugin still had a hard-coded reference to it in one place and was broken when I removed the old driver from core. To avoid this problem I am instead having this plugin use core's default driver, which in newer versions is StAX.
Testing done
I ran this plugin's tests against a core with XPP3 removed and observed they started failing. After this PR and jenkinsci/nested-view-plugin#43 they now pass.
Submitter checklist