JENKINS-73724 Remove jenkins junit plugin

[choweiyuan]

JIRA Link

https://issues.jenkins.io/browse/JENKINS-73724

Description

org.jenkins-ci.plugins:junit was added as part of this commit: Respect Mask Password plugin configuration · jenkinsci/logstash-plugin@31e8971 (github.com)

But then mask-passwords is no longer used now: remove dependency to maskpasswords by mwinter69 · Pull Request #48 · jenkinsci/logstash-plugin (github.com).

So this begs the question if org.jenkins-ci.plugins:junit serves any purpose? Should this be removed instead?

Removing it will make logstash plugin more lightweight: as junit plugin requires the following dependencies as listed on this web page: JUnit Jenkins plugin:
Dependencies
Bootstrap 5 API ≥ 5.3.2-3
Checks API ≥ 2.0.2
ECharts API ≥ 5.4.0-7
Ionicons API ≥ 70.v2959a_b_74e3cf
Plugin Utilities API ≥ 3.8.0
Pipeline: API ≥ 1291.v51fd2a_625da_7
Pipeline: Step API ≥ 657.v03b_e8115821b_
Display URL API ≥ 2.200.vb_9327d658781
Jackson 2 API ≥ 2.17.0-379.v02de8ec9f64c
Script Security ≥ 1335.vf07d9ce377a_e

Testing done

I tried running mvn test locally without it, seems to work fine.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[choweiyuan]

Apologies, seems like this is an oversight. Code doesn't actually compile after changing, not sure why mvn test works to begin with. I'll close this for now and look into it if I have time.