Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter missing non-compliant algorithms in FIPS mode #435

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

fcojfernandez
Copy link
Contributor

@fcojfernandez fcojfernandez commented Oct 14, 2024

fixes: #434

Missing some non-compliant algorithms in FIPS mode that were not filtered as part of #428 as they are using their own key derivation function (ConcatKDF)

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@fcojfernandez fcojfernandez merged commit 990b9d3 into jenkinsci:master Oct 14, 2024
19 checks passed
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.04%. Comparing base (f1b33c3) to head (40757e7).
Report is 18 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #435      +/-   ##
============================================
+ Coverage     72.01%   72.04%   +0.02%     
  Complexity      221      221              
============================================
  Files            17       17              
  Lines          1022     1023       +1     
  Branches        144      144              
============================================
+ Hits            736      737       +1     
  Misses          198      198              
  Partials         88       88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcojfernandez fcojfernandez deleted the issue-343 branch October 14, 2024 09:52
@fcojfernandez fcojfernandez changed the title Missing non-compliant algorithms in FIPS mode to filter Filter missing non-compliant algorithms in FIPS mode Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter FIPS non-compliant algorithms not filtered
2 participants