Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a FIPS compliant version of nimbus-jose-jwt #440

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

fcojfernandez
Copy link
Contributor

pac4j introduces a transitive dependency on nimbus-jose-jwt. Currently versions are pac4j-5.7.7 and nimbus-jose-jwt-9.37.2. Next nimbus-jose-jwt-9.41 fixes a couple of FIPS incompatibilities. While waiting for pac4j to bump that dependency we could force it in the plugin.

Diff doesn't show any problematic commit.

Testing done

Tested against keycloak. Existing tests pass.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@fcojfernandez fcojfernandez marked this pull request as ready for review October 24, 2024 14:06
@fcojfernandez fcojfernandez requested a review from a team as a code owner October 24, 2024 14:06
@fcojfernandez fcojfernandez merged commit ccc7061 into jenkinsci:master Oct 24, 2024
19 checks passed
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.04%. Comparing base (40757e7) to head (68e4d40).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #440   +/-   ##
=========================================
  Coverage     72.04%   72.04%           
  Complexity      221      221           
=========================================
  Files            17       17           
  Lines          1023     1023           
  Branches        144      144           
=========================================
  Hits            737      737           
  Misses          198      198           
  Partials         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcojfernandez fcojfernandez deleted the bump-nimbus-jose-jwt branch October 24, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants